Skip to content

Conversation

@lukaszstolarczuk
Copy link
Contributor

This PR is targeting v0.10.x because it's using UMF v0.9.x stable branch - v0.9.0 release, to be precise.
On the main branch here we use UMF's main as well.

@omarahmed1111, please note this PR will conflict with #2076 which contains a little older UMF's commit. Please let me know how do you want to handle it.

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner September 12, 2024 13:39
@github-actions github-actions bot added the common Changes or additions to common utilities label Sep 12, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Sep 12, 2024

@omarahmed1111, please note this PR will conflict with #2076 which contains a little older UMF's commit. Please let me know how do you want to handle it.

I think it would make sense to include this in #2076

# v0.9.x 19.08.2024: Merge pull request #688 ...
set(UMF_TAG 59c4150b7120a7af5b3c8eb2d9b8bbb5d2e96aa3)
# v0.9.x 12.09.2024: 0.9.0 release
set(UMF_TAG 57e819999a262b79bcceec47cca24f5015611ea1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a tag we could use here instead of the commit hash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, of course we have a tag... but we tend to use commits, as tags can be force-pushed, and not all forks/clones contain tags - if you prefer to use a tag I'll do that :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the release branches using a release tag like v0.9.0 makes it much clearer to see the tag is pointing to the correct place.

I'd hope that release tags aren't getting changed after creation...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we don't want to force-push tags, but it still possible.

Changed to tag.

@lukaszstolarczuk
Copy link
Contributor Author

@omarahmed1111, please note this PR will conflict with #2076 which contains a little older UMF's commit. Please let me know how do you want to handle it.

I think it would make sense to include this in #2076

Please note, that I want to target this PR only to v0.10.x branch - on main we use UMF's main.

@kbenzie
Copy link
Contributor

kbenzie commented Sep 12, 2024

@omarahmed1111, please note this PR will conflict with #2076 which contains a little older UMF's commit. Please let me know how do you want to handle it.

I think it would make sense to include this in #2076

Please note, that I want to target this PR only to v0.10.x branch - on main we use UMF's main.

Makes sense 👍

@omarahmed1111
Copy link
Contributor

omarahmed1111 commented Sep 12, 2024

@lukaszstolarczuk Thanks for updating me! I cherry-picked this commit to v0.10.4 PR: #2076 . Just to keep everything in one place, we would better I think merge this as part of #2076 PR.

@lukaszstolarczuk
Copy link
Contributor Author

@lukaszstolarczuk Thanks for updating me! I cherry-picked this commit to v0.10.4 PR: #2076 . Just to keep everything in one place, we would better I think merge this as part of #2076 PR.

do as you please :)

if you want me to change anything please let me (or @bratpiorka) know. I'll be out of office for a week (starting tomorrow).

@kbenzie
Copy link
Contributor

kbenzie commented Sep 13, 2024

This commit has been cherry-picked to v0.10.4rc as 2dfc006. Closing the PR.

@kbenzie kbenzie closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Changes or additions to common utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants