-
Notifications
You must be signed in to change notification settings - Fork 124
Bump UMF version to 0.9.0 release #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump UMF version to 0.9.0 release #2086
Conversation
I think it would make sense to include this in #2076 |
source/common/CMakeLists.txt
Outdated
| # v0.9.x 19.08.2024: Merge pull request #688 ... | ||
| set(UMF_TAG 59c4150b7120a7af5b3c8eb2d9b8bbb5d2e96aa3) | ||
| # v0.9.x 12.09.2024: 0.9.0 release | ||
| set(UMF_TAG 57e819999a262b79bcceec47cca24f5015611ea1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a tag we could use here instead of the commit hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, of course we have a tag... but we tend to use commits, as tags can be force-pushed, and not all forks/clones contain tags - if you prefer to use a tag I'll do that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the release branches using a release tag like v0.9.0 makes it much clearer to see the tag is pointing to the correct place.
I'd hope that release tags aren't getting changed after creation...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we don't want to force-push tags, but it still possible.
Changed to tag.
Please note, that I want to target this PR only to v0.10.x branch - on main we use UMF's main. |
Makes sense 👍 |
7bf32fe to
41ed6de
Compare
|
@lukaszstolarczuk Thanks for updating me! I cherry-picked this commit to |
do as you please :) if you want me to change anything please let me (or @bratpiorka) know. I'll be out of office for a week (starting tomorrow). |
|
This commit has been cherry-picked to v0.10.4rc as 2dfc006. Closing the PR. |
This PR is targeting v0.10.x because it's using UMF v0.9.x stable branch - v0.9.0 release, to be precise.
On the main branch here we use UMF's main as well.
@omarahmed1111, please note this PR will conflict with #2076 which contains a little older UMF's commit. Please let me know how do you want to handle it.