Skip to content

Add workaround for silently supported OpenCL extensions on Intel FPGA #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarahmed1111 merged 1 commit into from
Sep 11, 2024
Merged

Add workaround for silently supported OpenCL extensions on Intel FPGA #2078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions source/adapters/opencl/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ ur_result_t cl_adapter::getDeviceVersion(cl_device_id Dev,
return UR_RESULT_SUCCESS;
}

static bool isIntelFPGAEmuDevice(cl_device_id Dev) {
size_t NameSize = 0;
CL_RETURN_ON_FAILURE(
clGetDeviceInfo(Dev, CL_DEVICE_NAME, 0, nullptr, &NameSize));
std::string NameStr(NameSize, '\0');
CL_RETURN_ON_FAILURE(
clGetDeviceInfo(Dev, CL_DEVICE_NAME, NameSize, NameStr.data(), nullptr));

return NameStr.find("Intel(R) FPGA Emulation Device") != std::string::npos;
}

ur_result_t cl_adapter::checkDeviceExtensions(
cl_device_id Dev, const std::vector<std::string> &Exts, bool &Supported) {
size_t ExtSize = 0;
Expand All @@ -46,6 +57,14 @@ ur_result_t cl_adapter::checkDeviceExtensions(
Supported = true;
for (const std::string &Ext : Exts) {
if (!(Supported = (ExtStr.find(Ext) != std::string::npos))) {
// The Intel FPGA emulation device does actually support these, even if it
// doesn't report them.
if (isIntelFPGAEmuDevice(Dev) &&
(Ext == "cl_intel_device_attribute_query" ||
Ext == "cl_intel_required_subgroup_size")) {
Supported = true;
continue;
}
break;
}
}
Expand Down