fix ur_bool_t printing #2072
Merged
fix ur_bool_t printing #2072
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bool values were printed as ascii characters 0 or 1, leading to artifacts. This patch fixes this by printing either 'false' or 'true', depending on the bool's value. This has been annoying me a while when analyzing logs from SYCL apps.
pbalcer
force-pushed
the
ur-bool-print
branch
from
09c0904 to
d8ab934
Compare
igchor
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bool values were printed as ascii characters with code 0 or 1, leading to artifacts. This patch fixes this by printing either 'false' or 'true', depending on the bool's value.
This has been annoying me a while when analyzing logs from SYCL apps.