Skip to content

[Cuda] Check for exceeding grid dimension limits (work-group count) #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgeWeb wants to merge 1 commit into from
Closed

[Cuda] Check for exceeding grid dimension limits (work-group count) #2050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/adapters/cuda/enqueue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,18 @@ setKernelParams([[maybe_unused]] const ur_context_handle_t Context,
return UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE;
}

size_t MaxGridDim[3] = {0, 0, 0};
urDeviceGetInfo(Device, UR_DEVICE_INFO_MAX_WORK_GROUPS_3D,
sizeof(MaxGridDim), &MaxGridDim, nullptr);
for (size_t i = 0; i < WorkDim; i++) {
BlocksPerGrid[i] =
(GlobalWorkSize[i] + ThreadsPerBlock[i] - 1) / ThreadsPerBlock[i];

if (BlocksPerGrid[i] > MaxGridDim[i]) {
// Currently this is handled as an invalid value error. Revisit when a
// better alternative result error code is agreed on.
return UR_RESULT_ERROR_INVALID_VALUE;
}
}

// Set the implicit global offset parameter if kernel has offset variant
Expand Down