Skip to content

Fix CL adapter assuming incorrect type for sub group query. #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarahmed1111 merged 1 commit into from
Aug 19, 2024
Merged

Fix CL adapter assuming incorrect type for sub group query. #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions source/adapters/opencl/kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,19 +206,14 @@ urKernelGetSubGroupInfo(ur_kernel_handle_t hKernel, ur_device_handle_t hDevice,
// Two calls to urDeviceGetInfo are needed: the first determines the size
// required to store the result, and the second returns the actual size
// values.
ur_result_t URRet =
urDeviceGetInfo(hDevice, UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL, 0,
nullptr, &ResultSize);
if (URRet != UR_RESULT_SUCCESS) {
return URRet;
}
assert(ResultSize % sizeof(size_t) == 0);
std::vector<size_t> Result(ResultSize / sizeof(size_t));
URRet = urDeviceGetInfo(hDevice, UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL,
ResultSize, Result.data(), nullptr);
if (URRet != UR_RESULT_SUCCESS) {
return URRet;
}
UR_RETURN_ON_FAILURE(urDeviceGetInfo(hDevice,
UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL,
0, nullptr, &ResultSize));
assert(ResultSize % sizeof(uint32_t) == 0);
std::vector<uint32_t> Result(ResultSize / sizeof(uint32_t));
UR_RETURN_ON_FAILURE(urDeviceGetInfo(hDevice,
UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL,
ResultSize, Result.data(), nullptr));
RetVal = *std::max_element(Result.begin(), Result.end());
Ret = CL_SUCCESS;
} else if (propName == UR_KERNEL_SUB_GROUP_INFO_SUB_GROUP_SIZE_INTEL) {
Expand Down