Skip to content

Don't retain device handle references in sanitizer layer. #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbalcer merged 2 commits into from
Aug 2, 2024
Merged

Don't retain device handle references in sanitizer layer. #1883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55539ac
Don't retain device handle references in sanitizer layer.
aarongreig Jul 19, 2024
cb5cb6e
Add comment denoting change as a temporary fix.
aarongreig Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions source/loader/layers/sanitizer/asan_interceptor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,10 @@ struct DeviceInfo {
std::queue<std::shared_ptr<AllocInfo>> Quarantine;
size_t QuarantineSize = 0;

explicit DeviceInfo(ur_device_handle_t Device) : Handle(Device) {
[[maybe_unused]] auto Result =
getContext()->urDdiTable.Device.pfnRetain(Device);
assert(Result == UR_RESULT_SUCCESS);
}

~DeviceInfo() {
[[maybe_unused]] auto Result =
getContext()->urDdiTable.Device.pfnRelease(Handle);
assert(Result == UR_RESULT_SUCCESS);
}
// TODO: re-enable retaining and releasing device handles in DeviceInfo
// constructor/destructor. See PR
// https://github.com/oneapi-src/unified-runtime/pull/1883
explicit DeviceInfo(ur_device_handle_t Device) : Handle(Device) {}

ur_result_t allocShadowMemory(ur_context_handle_t Context);
};
Expand Down