-
Notifications
You must be signed in to change notification settings - Fork 120
[DeviceSanitizer] Fix interceptor destruction order #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
omarahmed1111
merged 15 commits into
oneapi-src:main
from
AllanZyne:review/yang/fix_dsan_destruction
Aug 16, 2024
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
df5fd8b
fix destruction
AllanZyne 6449148
Add UR_CALL
AllanZyne ae7dea6
using unordered_set
AllanZyne 9e6923f
wip
AllanZyne 56ed0b8
Merge branch 'llvm' into review/yang/fix_dsan_destruction
AllanZyne 5859e3c
fix crash
AllanZyne 982667e
fix repeat hold adapter handle
AllanZyne d67cfec
update test
AllanZyne fbecf2a
Merge branch 'llvm' into review/yang/fix_dsan_destruction
AllanZyne 250f759
add mutex for adapter
AllanZyne 864da64
fix test
AllanZyne 3e3bd51
Merge branch 'llvm' into review/yang/fix_dsan_destruction
AllanZyne e264cc1
address comments
AllanZyne 74d30dc
fix comments
AllanZyne fe18b4a
fix reviews
AllanZyne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
urAdapterGet()get called multiple times, then we would have duplicated handles.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we needn't hold the handle of adapter, it seems ur loader has already hold this.
I'll investigate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every time you call
urAdapterGet, an internal reference count is incremented and you need to decrement it usingurAdapterRelease.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed