[CTS] Fix virtual mem enqueue test #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hopefully this gets fixed by #805 instead, I guess I need to do a match file pass there |
|
Oh you're right I think #805 should fix it, I had a quick look through but missed it! And yes if you could remove the segfault pattern in that PR that would be good, I believe both CUDA and HIP don't crash anymore. |
|
Wait no, it's an enqueue test, so only CUDA should be fine, HIP is still crashing for other reasons, I'll remove the HIP segfault pattern later when all the fixes are merged |
npmiller
force-pushed
the
fix-virtual-mem-cts
branch
from
aa2675e to
a5d4a6a
Compare
|
Re-opening this as there are some issues with #805 so we can merge this first to fix the segfault while we figure out the larger PR. |
aarongreig
approved these changes
May 28, 2024
`urKernelSetArgPointer` doesn't take the argument pointer directly, it takes a pointer to the argument pointer. This fixes a crash in the CTS on CUDA.
Updating the match file after fixing segfault
npmiller
force-pushed
the
fix-virtual-mem-cts
branch
from
a5d4a6a to
1a96444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urKernelSetArgPointerdoesn't take the argument pointer directly, it takes a pointer to the argument pointer.This fixes a crash in the CTS on CUDA.