Invalid use of "std::filesystem"

[smaslov-intel]

This should be just "filesystem" not "std::filesystem":

unified-runtime/source/common/logger/ur_sinks.hpp

Line 172 in a6083f5

std::filesystem::path file_path = "",

Also testing with gcc 4.7.5 is needed, as it is used by some of dependecies

[smaslov-intel]

@pbalcer : will you add testing with older gcc?

[pbalcer]

We certainly want to expand the scope of testing we currently do, which includes having more OSes. See #457. This work is currently blocked by the need for our own infrastructure where we can run custom OS images. Using containers on GHA would not be sufficient.

However, none of the officially supported distros ship with a compiler this old. SYCL itself also says that it requires GCC version 7.1.0 or later.
While it would certainly be possible for us to create such a bespoke configuration to test with, we need to be mindful of keeping the matrix of supported platforms within a reasonable scope.

@kbenzie

[kbenzie]

intel/llvm is now requiring C++17 and UR follows this requirement. GCC 4.7.5 definitely does not support C++17 so I'm not sure how intel/llvm could be getting compiled with it.

In the first RHEL 7 bug report we got, the compiler toolchain in use was GCC 7.x even though the default toolchain in that distro is GCC 4.7.5. So it feels to me like that is the actual minimum bar for GCC toolchain support.