Docker workflow #1105
Docker workflow #1105
Conversation
changes: - created docker build and push workflow - created ubuntu 24.04 docker image - modified reuseable_fast and basic to work on docker image - modified pr/push to run build image when needed - added few installation to docker files
rbanka1
force-pushed
the
DockerWorkflow
branch
from
d1700d4 to
527baa9
Compare
| # Install hwloc | ||
| COPY .github/scripts/install_hwloc.sh /opt/umf/install_hwloc.sh | ||
| RUN apt-get update \ | ||
| && apt-get install -y dos2unix libtool \ |
There was a problem hiding this comment.
pls define deps as above using ARG and installing it as part of RUN apt ... command above
| && dos2unix /opt/umf/install_hwloc.sh \ | ||
| && bash -x /opt/umf/install_hwloc.sh \ | ||
| && ldconfig \ | ||
| && rm -f /opt/umf/install_hwloc.sh |
There was a problem hiding this comment.
no need for removing the script
| && apt-get install -y dos2unix libtool \ | ||
| && dos2unix /opt/umf/install_hwloc.sh \ | ||
| && bash -x /opt/umf/install_hwloc.sh \ | ||
| && ldconfig \ |
There was a problem hiding this comment.
are these 3 commands required?
There was a problem hiding this comment.
yes because without these commands there is a problem with windows line endings (\r)
|
|
||
| # Install lcov | ||
| RUN apt-get update && \ | ||
| apt-get install lcov -y |
There was a problem hiding this comment.
lcov is a MISC dependency (required only for coverage checking)
|
|
||
| # Install valgrind | ||
| RUN apt-get update && \ | ||
| apt-get install -y valgrind cmake hwloc libhwloc-dev libnuma-dev libtbb-dev |
There was a problem hiding this comment.
pls move it up, to test deps
.github/workflows/reusable_fast.yml
Outdated
| - name: Print metadata of our dll's | ||
| if: matrix.os == 'windows-latest' | ||
| run: | | ||
| get-command ${{github.workspace}}/build/bin/Release/umf.dll | format-list | ||
| get-command ${{github.workspace}}/build/src/proxy_lib/Release/umf_proxy.dll | format-list | ||
There was a problem hiding this comment.
something wrong here with EOF - there's should be just a single empty line at the end
| @@ -122,10 +189,9 @@ jobs: | |||
| working-directory: ${{env.BUILD_DIR}} | |||
| run: ctest --output-on-failure --test-dir test -C Release | |||
|
|
|||
| # TODO: We could add some script to verify metadata of dll's (selected fields, perhaps) | |||
There was a problem hiding this comment.
why remove this comment?
.github/workflows/reusable_fast.yml
Outdated
| fetch-depth: 0 | ||
|
|
||
| - name: Initialize vcpkg | ||
| if: matrix.os == 'windows-latest' |
There was a problem hiding this comment.
we only execute tests here in this job on windows-latest - these if's are no longer needed
.github/workflows/reusable_fast.yml
Outdated
| name: Fast builds (Linux) | ||
| runs-on: ${{ matrix.os }} | ||
| container: | ||
| image: ${{ matrix.os == 'ubuntu-latest' && 'ghcr.io/rbanka1/umf2-ubuntu-22.04:latest' || matrix.os == 'ubuntu-20.04' && 'ghcr.io/rbanka1/umf2-ubuntu-20.04:latest' }} |
There was a problem hiding this comment.
hmm... TBH, I'm not a fan on this solution - if we have e.g. 10 dockers this will become unreadable... But, I guess, we can figure it out later and leave it as is for now...
There was a problem hiding this comment.
I changed it to a more suitable solution for more dockers
.github/workflows/reusable_fast.yml
Outdated
| FastBuild: | ||
| name: Fast builds | ||
| FastBuild_Linux: | ||
| name: Fast builds (Linux) |
There was a problem hiding this comment.
Linux should be fine (we know it's a Fast builds job based on the workflow name 😉
Add Docker workflow
changes:
Checklist