[v3.7 backport] graph, benchdnn: several minor fixes for SDPA with mask #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaineBao
added
backport
component:graph-api
|
make test |
ElaineBao
force-pushed
the
yixin/backport_sdpa_minor_fix
branch
from
b1b65bd to
35e730a
Compare
|
make test |
ElaineBao
force-pushed
the
yixin/backport_sdpa_minor_fix
branch
from
35e730a to
215766d
Compare
|
make test |
rongzha1
approved these changes
Feb 13, 2025
ElaineBao
force-pushed
the
yixin/backport_sdpa_minor_fix
branch
from
215766d to
5f40724
Compare
|
make test |
TaoLv
approved these changes
Feb 13, 2025
dzarukin
approved these changes
Feb 13, 2025
| op_kind::dnnl_to_group, op_kind::dnnl_from_group, | ||
| op_kind::dnnl_permute, op_kind::dnnl_squeeze, | ||
| op_kind::dnnl_unsqueeze, op_kind::dnnl_transpose, | ||
| op_kind::dnnl_reshape, op_kind::dnnl_gen_index, op_kind::dnnl_mask}; |
There was a problem hiding this comment.
Nit: I'd add a comma at the end to keep previous formatting.
There was a problem hiding this comment.
reformatted, thanks
with negative axis value
ElaineBao
force-pushed
the
yixin/backport_sdpa_minor_fix
branch
from
5f40724 to
01a3978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport #2660 to rls-v3.7
This PR includes 3 minor fixes for SDPA with explicit or implicit mask:
[x] enhance check of axis in implicit causal mask to include negative axis (-1 & -2).
[x] support 1D / 2D mask for explicit causal mask (MFDNN-13164).
[x] add a internal attribute for internal op dnnl_gen_index for constant propagation (SET_ATTR_IS_CONSTANT)