Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu:aarch64: Extending support for BRGEMM General and 1x1 Forward Convolution #1983

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

kasturedeeksha
Copy link
Contributor

Description

This commit expands ARM SVE support for JIT SVE BRGEMM general and 1x1 forward convolution in FP32, introducing compatibility with various vector lengths. The changes made are for implementing different ARM SVE vector lengths.

Major code changes:

  1. generalized code by adding template with isa as argument.
  2. set predicate registers according to SVE length.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit? Yes
    Test output is same with and without this commit.
  1. make test output:
98% tests passed, 3 tests failed out of 195

Total Test time (real) = 1375.38 sec

The following tests FAILED:
        149 - test_graph_unit_dnnl_conv_usm_cpu (Failed)
        154 - test_graph_unit_dnnl_large_partition_usm_cpu (Failed)
        176 - test_benchdnn_modeC_graph_ci_cpu (Failed)
Errors while running CTest
  • Have you formatted the code using clang-format? Yes
    cc : @kawakami-k

src/cpu/aarch64/brgemm/jit_brgemm_kernel.cpp Outdated Show resolved Hide resolved
src/cpu/aarch64/jit_brgemm_conv.cpp Show resolved Hide resolved
src/cpu/aarch64/jit_brgemm_post_ops.hpp Outdated Show resolved Hide resolved
@mgouicem mgouicem merged commit c5e4ce7 into oneapi-src:main Jul 12, 2024
8 of 10 checks passed
@vpirogov vpirogov added this to the v3.6 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants