gpu: sycl: sum: implemented #1940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4c1
force-pushed
the
john/sycl_sum_impl
branch
2 times, most recently
from
479719a
to
70d31dc
Compare
|
Is the CI timing out on Win Server 2022 expected? I have the same happening on another PR after rebasing on main, just like on this one. |
|
@t4c1, these timeouts are expected. Looks like MSVC update from 19.39.33523.0 to 19.40.33811.0 in Azure environment breaks |
kala855
approved these changes
Jul 11, 2024
mgouicem
reviewed
Jul 12, 2024
src/xpu/sycl/types.hpp
Outdated
| #define DNNL_ARG_SRC_14 15 | ||
| #define DNNL_ARG_SRC_15 16 | ||
|
|
||
| #define MAX_NUM_TENSORS 16 |
There was a problem hiding this comment.
Is this specific to sycl sum implementation? If so I would advice to name it accordingly (e.g. DNNL_REF_SUM_MAX_NUM_TENSORS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SYCL implementation for sum primitive. There is one implementation that handles up to 16 inputs and another one that repeatedly uses the first one for more inputs.
co-authored with @kala855