-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: aarch64: matmul: Move allocation of temporary tensors to scratchpad in acl_matmul #1935
Conversation
tagging @snadampal as this relates to #1470 |
+@snadampal, could you please help reviewing these changes? @annop-w, please resolve merge conflict. |
…pad in acl_matmul Introduce 3 new scrathpad memory key names.
Done. |
glad to see this change finally coming. |
@snadampal I am not sure how the scratchpads are currently managed in ideep (or Tensorflow), but the idea here is to allow for users (i.e. PyTorch or TF) a chance to decide that, isn't it ? For example, PyTorch can now choose to allocate the same buffer for both src and wei, if sensible, which was not possible before. Does this help ? |
i mean reusing the buffer allocated in PT or TF via oneDNN user mode scratchpad, you clarified it, thanks. |
@snadampal Ah, yes, in that case, you're absolutely right. Thanks for the review. |
Awesome. Thanks, @snadampal. |
Description
Introduce 3 new scrathpad memory key names.
Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?