gpu: sycl: eltwise: Reduce size of kernel arguments #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzarukin
reviewed
May 28, 2024
sgeor255
force-pushed
the
svet/reduce-eltwise-arg-size
branch
from
a5a53e4
to
8291d5b
Compare
sgeor255
force-pushed
the
svet/reduce-eltwise-arg-size
branch
from
8291d5b
to
61bf2bb
Compare
dzarukin
approved these changes
Jul 9, 2024
sgeor255
requested review from
kala855,
t4c1,
ShanoToni and
dylan-angus-codeplay
kala855
approved these changes
Jul 10, 2024
t4c1
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR slightly refactors the eltwise SYCL kernel to remove some unused data that was stored in the conf struct passed to the kernel. As a result, the size of the struct is reduced, allowing the kernel to run on some specific devices with a lower kernel argument size limit.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?