[Python Migration] Separated common IPEX and PyTorch rules #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflinda
reviewed
Feb 6, 2025
zhiweij1
approved these changes
Feb 6, 2025
ziranzha
approved these changes
Feb 12, 2025
zhimingwang36
requested changes
Feb 13, 2025
|
The Linux & Win CPU CI have an expected failure in help_option_check.cpp (PR#2665 is already raised) |
tomflinda
reviewed
Feb 18, 2025
| } | ||
|
|
||
| // Get the directory path of the rule file. | ||
| llvm::SmallString<128> directoryPath(ruleFilePath); |
There was a problem hiding this comment.
For the variable naming styles, please use the camel case style, just like the other code style in the DPCT folder.
tomflinda
reviewed
Feb 18, 2025
|
|
||
| // Get the directory path of the rule file. | ||
| llvm::SmallString<128> directoryPath(ruleFilePath); | ||
| llvm::sys::path::remove_filename(directoryPath); |
tomflinda
reviewed
Feb 18, 2025
| // Split the file content into lines using newline as the delimiter. | ||
| llvm::StringRef buffContent = std::move(*Buffer)->getBuffer(); | ||
| llvm::SmallVector<StringRef, 16> lines; | ||
| buffContent.split(lines, "\n"); |
There was a problem hiding this comment.
Using '\n' to split the file, we should make sure the content of the YAML file is ended with '\n' for each line.
zhiweij1
reviewed
Feb 18, 2025
| // Extract the filename following !include. | ||
| std::istringstream iss(lineStr); | ||
| std::string incDirective, incRuleFilePath; | ||
| // iss >> incDirective >> incRuleFilePath; |
zhiweij1
reviewed
Feb 18, 2025
Comment on lines
+374
to
+409
| // Extract the filename following !include. | ||
| std::istringstream iss(lineStr); | ||
| std::string incDirective, incRuleFilePath; | ||
| // iss >> incDirective >> incRuleFilePath; | ||
| iss >> incDirective; | ||
| std::getline(iss >> std::ws, incRuleFilePath); | ||
|
|
||
| // Trim trailing spaces from incRuleFilePath | ||
| incRuleFilePath.erase(incRuleFilePath.find_last_not_of(" \t\n\r\f\v") + 1); | ||
|
|
||
| if (incDirective == "!include") { | ||
| if (!incRuleFilePath.empty()) { | ||
| // Remove surrounding quotes if they exist. | ||
| if (incRuleFilePath.front() == '"' && incRuleFilePath.back() == '"') { | ||
| incRuleFilePath = | ||
| incRuleFilePath.substr(1, incRuleFilePath.size() - 2); | ||
| } | ||
|
|
||
| // Calculate the absolute path of the included file based on its parent | ||
| // rule file | ||
| llvm::SmallString<128> incRuleFileAbsPath = directoryPath; | ||
| llvm::sys::path::append(incRuleFileAbsPath, incRuleFilePath); | ||
|
|
||
| // Recursively process the included file. | ||
| if (llvm::sys::fs::exists(incRuleFileAbsPath)) { | ||
| output << readYAMLFile(incRuleFileAbsPath.str())->getBuffer().str() | ||
| << "\n"; | ||
| } else { | ||
| output << readYAMLFile(incRuleFilePath)->getBuffer().str() << "\n"; | ||
| } | ||
| } else { | ||
| continue; | ||
| } | ||
| } else { | ||
| output << lineStr << "\n"; | ||
| } |
There was a problem hiding this comment.
I think a single for-loop is enough to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates common rules from IPEX & PyTorch rule files into a new rule file and appends them to the user selected rule file