Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces small "Throbber" icon with a full page loading overlay. #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaces small "Throbber" icon with a full page loading overlay. #299

wants to merge 1 commit into from

Conversation

lucanos
Copy link
Contributor

@lucanos lucanos commented Oct 26, 2020

The previous throbber was so small that it was easy to miss it.

nelson6e65
nelson6e65 suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@nelson6e65 nelson6e65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indentation change is unnecessary.

@ondras
Copy link
Owner

ondras commented Nov 24, 2020

I think the indentation change is unnecessary.

Right, please, submit only the throbber change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelson6e65 nelson6e65 nelson6e65 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucanos @ondras @nelson6e65