Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled save button #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

disabled save button #178

wants to merge 1 commit into from

Conversation

Light13008
Copy link

disabled save button under Generiv WebDAV, changed the input type to 'url' and checked the button only after filling the input field.

disabled save button under Generiv WebDAV, changed the type to url and checked the button only after filling the input field.
@ondras
Copy link
Owner

ondras commented Oct 5, 2023

Hi @Light13008 ,

thanks for your contribution. Unfortunately, this is not sufficient. The my-mind.js file is automatically generated during the build process, so your code will get overwritten every time the app is built.

You need to add your code somewhere inside the real source code (the src/ subdirectory) and re-build the project yourself (via make). Ideally to https://github.com/ondras/my-mind/blob/master/src/ui/backend/webdav.ts - this module corresponds to the WebDAV UI.

Furthermore:

  • do not add the id attribute (dangerous! there may be more URL-related inputs in the app); instead, use the this.url property of the WebDAVUI class
  • to retrieve the button, try this.go
  • instead of doing removeAttribute/setAttribute, just set button.disabled

@Light13008
Copy link
Author

Thanks for your insights, I will surely get the changes done soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants