Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthru of graphviz node shape,style #84

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Conversation

Russtopia
Copy link
Contributor

Addition of -nodeshape and -nodestyle to allow some customization of output visuals

@Russtopia
Copy link
Contributor Author

Russtopia commented May 30, 2021

I kind of forgot about this PR. Any objection to it? It just adds ability to let the user style the graph nodes.

Thanks,
-Russ

@suntong
Copy link

suntong commented Aug 2, 2021

Bump

@Russtopia
Copy link
Contributor Author

Russtopia commented Aug 2, 2021

Bump

Hmm, seems @ofabry is not giving attention lately to anything other than private repos according to his github activity ... if you want this feature, go grab my fork over at https://github.com/Russtopia/go-callvis/tree/node-styles for now.

Hopefully someday he'll be back to merge here :)

@ondrajz
Copy link
Owner

ondrajz commented Aug 2, 2021

Hey @Russtopia thanks for the PR and sorry for the delay. Work and life keeping me busy..

Could you please update the PR and pass the parameters via graph's Options field similarly to minlen. The dot template should not really have access to the raw flags anyway.

@Russtopia
Copy link
Contributor Author

Russtopia commented Aug 3, 2021

Hey @Russtopia thanks for the PR and sorry for the delay. Work and life keeping me busy..

Could you please update the PR and pass the parameters via graph's Options field similarly to minlen. The dot template should not really have access to the raw flags anyway.

Understood :) I've updated it to use the templating as minlen does -- seems to work locally. Hope that's more in style with what you wanted!

Cheers, -R.

@ondrajz ondrajz merged commit 15d59ba into ondrajz:master Aug 23, 2021
@Russtopia Russtopia deleted the node-styles branch August 24, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants