feat: use manifest.minimum_chrome_version as XML's prodversionmin
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to '29.0.0' for CRX2 and '70.0.0' for CRX3.
arkon
reviewed
Mar 30, 2019
ahwayakchih
added a commit
to ahwayakchih/crx3
that referenced
this pull request
Mar 31, 2019
Thanks to @arkon for pointing out (thom4parisot/crx#102 (comment)) to check chrome/VERSION file.
That's the version at which Chrome switched to generating CRX3 packages, as found out with help of @arkon (thom4parisot#102 (comment))
arkon
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to '29.0.0' for CRX2 and '70.0.0' for CRX3.
Fixes: #13