Skip to content

Commit

Permalink
fix: change default minimum browser version to 64.0.3242
Browse files Browse the repository at this point in the history
Thanks to @arkon for pointing out (thom4parisot/crx#102 (comment)) to check chrome/VERSION file.
  • Loading branch information
ahwayakchih committed Mar 31, 2019
1 parent 12c548d commit 2a09abb
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions lib/writeCRX3File.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,19 @@ function writeFromListOfFiles (crxStream, files) {
/**
* Require minimum browser version.
*
* Guessed by date when Chromium was switched to generate CRX3 packages,
* and Chrome version number around 1 year later.
* Guessed by date when Chromium was switched to generate CRX3 packages (October 16, 2017).
*
* Chrome made CRX3 mandatory in version 73.0.3683.
*
* @see
* [Chromium commit]{@link https://chromium.googlesource.com/chromium/src.git/+/b8bc9f99ef4ad6223dfdcafd924051561c05ac75}
* @see
* [Chrome versions]{@link https://en.wikipedia.org/wiki/Google_Chrome_version_history}
* [Chrome version at that commit]{@link https://chromium.googlesource.com/chromium/src/+/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/chrome/VERSION}
* @see
* [Chrome version history]{@link https://en.wikipedia.org/wiki/Google_Chrome_version_history}
* @private
*/
const BROWSER_VERSION_MINIMUM = '70';
const BROWSER_VERSION_MINIMUM = '64.0.3242';

/**
* Write Update Manifest template.
Expand All @@ -163,15 +164,13 @@ const BROWSER_VERSION_MINIMUM = '70';
*
* @see
* [Update Manifest]{@link https://developer.chrome.com/extensions/linux_hosting#update_manifest}
* @see
* [Chrome Versions]{@link https://en.wikipedia.org/wiki/Google_Chrome_version_history}
* @private
* @param {string} filePath
* @param {string} appId
* @param {Object} [info]
* @param {string} [info.version='${APP_VERSION}']
* @param {string} [info.url='${CRX_URL}']
* @param {string} [info.browser='70']
* @param {string} [info.browser='64.0.3242']
*/
function writeUpdateManifestXML (filePath, appId, info = {}) {
info.version = info.version || process.env.APP_VERSION || '${APP_VERSION}';
Expand Down

0 comments on commit 2a09abb

Please sign in to comment.