Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track password edit #1456

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Track password edit #1456

merged 4 commits into from
Aug 21, 2018

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Aug 20, 2018

Once a user changes his/her password, track the last time this edit is done.

lincmba added 2 commits August 20, 2018 12:16
@lincmba
Track password edits
b3fd15b 
 Once a user changes his/her password, track the last time this edit is done.
@lincmba
Remove unused imports
4afcbc1
@lincmba lincmba requested a review from moshthepitt August 20, 2018 09:23
pld
pld requested changes Aug 20, 2018
View reviewed changes
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test ensuring that the user must be authenticated as themselves to view this information

@lincmba
Copy link
Contributor Author

lincmba commented Aug 20, 2018

fixes #1454

@lincmba
Copy link
Contributor Author

lincmba commented Aug 21, 2018

@pld suggested changes have been made. Review.

@moshthepitt moshthepitt merged commit aced16c into master Aug 21, 2018
@moshthepitt moshthepitt deleted the track_password_edit branch August 21, 2018 19:38
@moshthepitt moshthepitt mentioned this pull request Aug 21, 2018
Closed
ukanga added a commit that referenced this pull request Sep 3, 2018
@ukanga
Revert "Merge pull request #1456 from onaio/track_password_edit"
a7d7a88 
This reverts commit aced16c, reversing
changes made to a5b4303.
ukanga added a commit that referenced this pull request Sep 3, 2018
@ukanga
Revert "Merge pull request #1456 from onaio/track_password_edit"
462f20e 
This reverts commit aced16c, reversing
changes made to a5b4303.

This changes result in the exception posted on issue
#1467. There is need to rethink
how the functionality should be implemented.
@moshthepitt moshthepitt restored the track_password_edit branch September 3, 2018 14:09
ukanga added a commit that referenced this pull request Sep 3, 2018
@ukanga
Revert "Merge pull request #1456 from onaio/track_password_edit"
a1308bd 
This reverts commit aced16c, reversing
changes made to a5b4303.

This changes result in the exception posted on issue
#1467. There is need to rethink
how the functionality should be implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pld pld pld approved these changes

@moshthepitt moshthepitt moshthepitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lincmba @pld @moshthepitt