Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose OutcomeDocument #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dinoboff
Copy link

@dinoboff dinoboff commented Aug 17, 2017

Allow using an alternative http client or nodejs http(s) client with non default options.

  • Add static methods to OutcomeDocument to create read/delete/replace outcome request body
  • Refactor how the score language and the supported type are given to the Outcome Document.
  • Expose the outcome service response parser

@dinoboff dinoboff force-pushed the feat/outcome-sign-request-method branch 2 times, most recently from bafcc41 to 379f9fa Compare August 17, 2017 14:16
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Changes Unknown when pulling 379f9fa on dinoboff:feat/outcome-sign-request-method into ** on omsmith:master**.

@dinoboff dinoboff force-pushed the feat/outcome-sign-request-method branch from 379f9fa to 199e5a2 Compare August 23, 2017 12:05
@dinoboff dinoboff changed the title feat: OutcomeService method to prepare request feat: Expose OutcomeDocument Aug 23, 2017
@dinoboff dinoboff force-pushed the feat/outcome-sign-request-method branch 4 times, most recently from b8c88c5 to 6ef92ec Compare August 23, 2017 12:30
@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Changes Unknown when pulling 6ef92ec on dinoboff:feat/outcome-sign-request-method into ** on omsmith:master**.

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Changes Unknown when pulling 3b5fb45 on dinoboff:feat/outcome-sign-request-method into ** on omsmith:master**.

Allow using a alternative http client (e.g. like `request` or nodejs http(s) with non default options).

Add static methods to OutcomeDocument to create read/delete/replace outcome request body and refactor how the score language and the supported type are given to the Outcome Document.
@dinoboff dinoboff force-pushed the feat/outcome-sign-request-method branch from 3b5fb45 to 2347d2e Compare August 24, 2017 12:26
@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling 2347d2e on dinoboff:feat/outcome-sign-request-method into ** on omsmith:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants