Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured configs #86

Merged
merged 3 commits into from
Dec 25, 2019
Merged

Structured configs #86

merged 3 commits into from
Dec 25, 2019

Conversation

omry
Copy link
Owner

@omry omry commented Nov 23, 2019

Closes #87
Closes #101
Closes #102
Closes #103
Closes #88
Closes #99

@coveralls

This comment has been minimized.

omegaconf/dictconfig.py Outdated Show resolved Hide resolved
@omry omry changed the title Code config WIP Structured configs Nov 30, 2019
@tamuhey

This comment has been minimized.

@tamuhey

This comment has been minimized.

omegaconf/utils.py Outdated Show resolved Hide resolved
omegaconf/utils.py Outdated Show resolved Hide resolved
@omry
Copy link
Owner Author

omry commented Dec 5, 2019

Progress:
support for Optional[T], List[T] and Dict[str, T] added.
T is limited to supported simple types (str, int, float, bool and enum)

@omry
Copy link
Owner Author

omry commented Dec 22, 2019

This is functionally complete as far as I can tell.
I would appreciate a review pass on the docs and on the tests (especially changed tests)

@omry omry force-pushed the code_config branch 2 times, most recently from 16286d5 to fc58310 Compare December 24, 2019 15:34
@omry omry merged commit 7c54df2 into master Dec 25, 2019
@omry omry deleted the code_config branch December 26, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants