Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging of redundant keys #1121

Closed
wants to merge 11 commits into from

Conversation

MatteoVoges
Copy link
Contributor

@MatteoVoges MatteoVoges commented Sep 4, 2023

sorry I chose the wrong target branch

@MatteoVoges MatteoVoges closed this Sep 4, 2023
@MatteoVoges MatteoVoges deleted the try-escape-interpolations branch September 4, 2023 07:48
@@ -275,6 +276,9 @@
target = _ensure_container(target)
assert isinstance(target, (DictConfig, ListConfig))

global log_file
log_file = log_filename

Check notice

Code scanning / CodeQL

Unused global variable Note

The global variable 'log_file' is not used.
@@ -317,6 +322,9 @@
target = _ensure_container(target)
assert isinstance(target, (DictConfig, ListConfig))

global log_file
log_file = log_filename

Check notice

Code scanning / CodeQL

Unused global variable Note

The global variable 'log_file' is not used.
@@ -6,6 +6,8 @@

import yaml

import omegaconf

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'omegaconf' is imported with both 'import' and 'import from'.
f"value '{node}' is defined redundantly in '{node._get_full_key('')}'",
file=file,
)
except:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.
f"value '{node}' is defined redundantly in '{node._get_full_key('')}'",
file=file,
)
except:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
@MatteoVoges MatteoVoges restored the try-escape-interpolations branch September 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant