Fixes for systemd unit #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option -r <pidfile> for resmon. If none provided it will run without creating pidfile. If provided, it will try write it's pid into specified file. Resmon-systemd.service should have this file as an argument for resmon as a PIDFile option and in ExecStart option.
resmon
Outdated
| close PIDFILE or die "can't close $PIDFILE"; | ||
| } | ||
| exit; | ||
| } |
There was a problem hiding this comment.
Could fix style (spaces around operators and commas) if that matters.
Not sure about convention here, but maybe lowercase the $PIDFILE var so it doesn't look like the file handle PIDFILE, or just keep using $config->{pidfile}.
There was a problem hiding this comment.
Please use the three-arg form of open(), instead of the two-arg form with string interpolation, and scalar filehandles instead of barewords:
open(my $pidfh, '>', $config->{pidfile}) or die "can't open $config->{pidfile}";
|
Thanks, updated pull request. |
'==' can not compare file handles. We can use fileno() function to compare numerically file numbers. Code without this returns "connection successful" when it timeouts and $fd is "undefined".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo fixed, thanks to @yakatz. Fixed excessive restarting of the unit and provided PIDFile for systemd.