Upgrade librabbitmq version to 0.4 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've created a 0.5.0_dev branch with this pull request incorporated. Also made it an actual extension update and fixed the config table to dump its data. I've tested all the basic functionality of the included sql functions and things seem to be working. If anyone can provide a more thorough evaluation in a more realistic environment that would be great. @marcelloceschia If you want to try and incorporate your ssl patch against this branch, please feel free. |
|
I am currently testing this with 0.5.0 on Windows. Seems to be working. |
|
@j16sdiz Did you ever have any luck here? I know this is a bit out of date. I think librabbitmq is on 0.8 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix issue #16 as well.
I have run this for a few hours on Debian Linux and it seems to work fine.
But there are few this I am not qualify to check:
select()(instead of detecting to epoll() support), guess this should be cross platform....close(sockfd)because the new library does not expose the raw socket. According to this post, it should work. But it may need more careful review.