Conversation
Signed-off-by: Kyle Van Landingham <kyle.vanlandingham@databricks.com>
This was referenced Jun 26, 2026
This was referenced Aug 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1059
Summary
Type of change
Test coverage
Coverage rationale
Vitest coverage exercises the hotkey predicate, Cmd/Ctrl variants, ignored chords, sidebar open-before-focus behavior, actual search input focus/selection, and the keyboard shortcuts dialog row.
Playwright coverage in
tests/e2e_ui/sessions/test_sidebar_search.pyverifies Ctrl+Shift+F opens a collapsed sidebar and focuses/selects the search input in the browser.Validated locally:
npm test -- src/hooks/useSessionSearchHotkey.test.tsx src/components/KeyboardShortcutsDialog.test.tsx src/shell/Sidebar.test.tsx src/lib/panelSizePreferences.test.ts src/hooks/useResizableSidebar.test.tsxnpx oxlint src/hooks/useSessionSearchHotkey.ts src/hooks/useSessionSearchHotkey.test.tsx src/shell/Sidebar.tsx src/shell/Sidebar.test.tsx src/components/KeyboardShortcutsDialog.tsx src/components/KeyboardShortcutsDialog.test.tsx src/test-setup.tsnpm run type-checknpm run format:check -- src/hooks/useSessionSearchHotkey.ts src/hooks/useSessionSearchHotkey.test.tsx src/shell/Sidebar.tsx src/shell/Sidebar.test.tsx src/components/KeyboardShortcutsDialog.tsx src/components/KeyboardShortcutsDialog.test.tsx src/test-setup.tsnpm run builduv run --python /opt/homebrew/bin/python3.13 pytest tests/e2e_ui/sessions/test_sidebar_search.py --ui-skip-build -qNote: full
npm run lintcurrently reports existing errors outside this change; focusedoxlinton the touched TS/TSX files passes.