Introduce refactored token contracts #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
approved these changes
Apr 1, 2021
k1rill-fedoseev
force-pushed
the
feature/new-token-contracts
branch
from
e4001c9 to
92de2c7
Compare
|
Consider to rework the solution by including the precompiled token contract prepared under omni/tokenbridge-contracts#618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Previously, OB used a precompiled tokens taken from
tokenbridge-contractsrepo written on solc 0.4.24.In order to implement #21, it was required to rewrite the tokens on the newer solidity version used in this repo.
I have preserved the original storage slots layout used in old tokens contract. This might be required in case of existing contracts upgrade via a hard-fork. The storage layout of the openzeppelin token contracts evolved a little bit, so it was necessary to modify them a little bit (see
contracts/tokens/README.md).Regarding #21: