Be able to filter when retrieving a Refund List from a Charge object. #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is a case that user wants to retrieve a Refund List in
reverse_chronological
order from a Charge Object.With the current code, it is impossible to achieve the above use case as there is no way to pass those filters when retrieving Refund List object from a Charge object.
Quality Assurance
Execute the following 2 code
and
The second code should alter the result of the Refund List object.
Additional Notes
In the previous, the following code will always fetch a new Refund List object from Omise API.
But after the change, if there is no
filter
option passing through the$charge->refunds();
method the code will instead, assign$this['refunds']
toOmiseRefundList
object (no request to Omise API).