Apply PSR Code Styling Standard to the library #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzzilar
force-pushed
the
apply-psr-standards
branch
from
49d6dd6 to
8f74603
Compare
guzzilar
force-pushed
the
apply-psr-standards
branch
from
8f74603 to
53110c5
Compare
guzzilar
changed the title
jacstn
approved these changes
Nov 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
There are bunch of legacy codes that don't comply with the PSR-2 Code Standard.
This pull request is aiming to clean up those legacy codes.
2. Description of changes
Apply PSR-2 Code Standard to the library.
However, there is still 1 leftover place that won't be updated in this pull request, which is OmiseException class.
The reason is that this class will be refactor later on in the coming pull request. (as it requires more than just update code styling but more on a refactoring part. So I leave it for an appropriate pull request).
