Include PHP Version to the USER-AGENT header when make a request to Omise API. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwat
reviewed
Mar 21, 2017
lib/omise/res/OmiseApiResource.php
Outdated
| @@ -250,7 +250,7 @@ private function _executeTest($url, $requestMethod, $key, $params = null) | |||
| */ | |||
| private function genOptions($requestMethod, $userpwd, $params) | |||
| { | |||
| $user_agent = "OmisePHP/".OMISE_PHP_LIB_VERSION; | |||
| $user_agent = "OmisePHP/" . OMISE_PHP_LIB_VERSION . " PHP/" . phpversion(); | |||
There was a problem hiding this comment.
It seems that current coding convention does not have spaces between dot (.) used for concatenation. Does this matter?
There was a problem hiding this comment.
@iwat nice catch 👍 yah, usually I have 1 space between string concat in other plugin projects.
But better to not do it here for now, as you mentioned.
Will remove
There was a problem hiding this comment.
Note that the version string returned by phpversion() may include more information than expected: "5.5.9-1ubuntu4.17", for example. source
|
👍 LGTM Unit test passed on 5.3, 5.5, 5.6, 7.0, 7.1. |
|
👍 |
guzzilar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Enhance Omise-PHP library, that Omise can provide an appropriate and better support on each of PHP environment by knowing PHP version from clients.
Related information:
Related issue(s): 🙅
2. Description of change
USER-AGENTheader when make a request to the Omise APIs.3. Quality assurance
🔧 Environments:
✏️ Details:
Try make any request to Omise API, at the requested log in Omise dashboard, you will see
PHP/x.y.zappeared at theUSER AGENTsection.4. Impact of the change
No impact.
5. Priority of change
Normal.
6. Additional Notes