Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite publickey and secretkey as null for OmiseSearch::scope #149

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Do not overwrite publickey and secretkey as null for OmiseSearch::scope #149

merged 1 commit into from
Apr 5, 2023

Conversation

nicodemuz
Copy link
Contributor

Objective

Do not overwrite publickey and secretkey as null for OmiseSearch::scope

How Has This Been Tested

Not tested.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nicodemuz nicodemuz requested a review from ajzkk as a code owner April 4, 2023 16:13
@ajzkk ajzkk requested a review from aashishgurung April 5, 2023 01:41
aashishgurung
aashishgurung approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@aashishgurung aashishgurung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing this. Greatly appreciated.

@ajzkk ajzkk merged commit fbf50cf into omise:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajzkk ajzkk ajzkk approved these changes

@aashishgurung aashishgurung aashishgurung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicodemuz @aashishgurung @ajzkk