Define glTF Object Model properties for OMI extensions #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
gltf-obj-model
branch
from
0df0217
to
5073245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because this depends on #226 (they would otherwise conflict, so I had to choose one to go first).
This PR adds glTF Object Model property definitions for all OMI extensions, except OMI_physics_joint (pending rework) and OMI_collider (archived).
Note that this PR is not the be-all end-all of OMI's support for the glTF Object Model. It is also important that we define things like how triggers interact with interactivity, or how one might play audio or apply a force. However, this PR is the start, defining at least the properties, which will work for KHR_animation_pointer, and already have known established best practices. Also, for physics, this aligns with Eoin's Microsoft/KHR physics repo which has these already.