test: add in-flight exit deletion test #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgebal
force-pushed
the
pgebal/add_ife_deleted_test
branch
2 times, most recently
from
c75125f
to
f7c6070
Compare
InoMurko
approved these changes
Sep 2, 2020
ayrat555
approved these changes
Sep 2, 2020
| @@ -56,9 +56,19 @@ Feature: In Flight Exits | |||
| Given "Alice" deposits "10" ETH to the root chain | |||
| Then "Alice" should have "10" ETH on the child chain after finality margin | |||
| Given Alice creates a transaction for "5" ETH | |||
| And Alice starts an in flight exit from the most recently created transaction | |||
| And "Alice" starts an in flight exit from the most recently created transaction | |||
There was a problem hiding this comment.
why some lines use quoted Alice, some lines don't?
There was a problem hiding this comment.
At first I've come up with more complex test that involved Bob. I wanted to reuse code for Bob so I "quoted" Alice. Later I simplified the test but left Alice "quoted".
pgebal
force-pushed
the
pgebal/add_ife_deleted_test
branch
from
f7c6070
to
36eedb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing fix for omgnetwork/private-issues#35
Tests changes introduced in omgnetwork/elixir-omg#1701