Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

Enables BRIDGE ALL for ETH#563

Merged
CAPtheorem merged 12 commits intodevelopfrom
Enable-BRIDGE-ALL-L2--L1-for-ETH
Oct 6, 2021
Merged

Enables BRIDGE ALL for ETH#563
CAPtheorem merged 12 commits intodevelopfrom
Enable-BRIDGE-ALL-L2--L1-for-ETH

Conversation

@CAPtheorem
Copy link

@CAPtheorem CAPtheorem commented Oct 4, 2021

Enables BRIDGE ALL for ETH, so that all ETH can be moved from L2 to L1 if desired.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #563 (6b67cd0) into develop (33c33ca) will increase coverage by 7.92%.
The diff coverage is n/a.

❗ Current head 6b67cd0 differs from pull request most recent head 45feecf. Consider uploading reports for the commit 45feecf to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
+ Coverage    76.07%   84.00%   +7.92%     
===========================================
  Files           81       59      -22     
  Lines         3039     2182     -857     
  Branches       469      342     -127     
===========================================
- Hits          2312     1833     -479     
+ Misses         727      349     -378     
Flag Coverage Δ
batch-submitter ?
contracts 86.00% <ø> (ø)
core-utils 68.16% <ø> (ø)
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/l1-ingestion/handlers/state-batch-appended.ts
.../l1-ingestion/handlers/sequencer-batch-appended.ts
packages/message-relayer/hardhat.config.ts
packages/batch-submitter/hardhat.config.ts
packages/data-transport-layer/src/utils/common.ts
...ices/l1-ingestion/handlers/transaction-enqueued.ts
...ckages/data-transport-layer/src/utils/constants.ts
...ackages/batch-submitter/src/utils/tx-submission.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
packages/message-relayer/src/relay-tx.ts
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c33ca...45feecf. Read the comment docs.

@CAPtheorem CAPtheorem changed the title wip - do not merge Enables BRIDGE ALL for ETH Oct 5, 2021
@CAPtheorem CAPtheorem requested a review from sk-enya October 5, 2021 00:12
@jet86
Copy link

jet86 commented Oct 5, 2021

Will fix #376

@CAPtheorem CAPtheorem merged commit 034e7d3 into develop Oct 6, 2021
@CAPtheorem CAPtheorem deleted the Enable-BRIDGE-ALL-L2--L1-for-ETH branch October 6, 2021 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments