This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
wallet deployer + integration test #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
3cd29ac
to
16ad336
Compare
Codecov Report
@@ Coverage Diff @@
## develop #33 +/- ##
===========================================
+ Coverage 80.60% 82.26% +1.65%
===========================================
Files 50 49 -1
Lines 1939 1900 -39
Branches 311 303 -8
===========================================
Hits 1563 1563
+ Misses 376 337 -39 Continue to review full report at Codecov.
|
|
Looks good to me. The file conflicts are simple to resolve (.github/workflows/omgx-publish-develop.yml) - did not touch that. |
CAPtheorem
approved these changes
Jun 7, 2021
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
62b0b5e
to
667be7d
Compare
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
ad36827
to
6897019
Compare
|
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
026d6a3
to
0043f3a
Compare
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
5 times, most recently
from
eebfabe
to
836e7d3
Compare
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
2 times, most recently
from
534549f
to
b91b793
Compare
InoMurko
commented
Jun 16, 2021
| yarn test:integration:ovm | ||
| yarn deploy:ovm | ||
|
|
||
| - name: Test serving Wallet contracts |
There was a problem hiding this comment.
with this we ensure wallet deployer deploys contracts, later we will add wallet integration tests
There was a problem hiding this comment.
but we need to run all their integration tests so that we make sure our stack does not interfere with the correctness of the optimistic system
yarn change and test for wallet deployment modify omgx integration and add cleanup to package json command pass in no-cache flag copy patches to monorepo integration and deamon integration and deamon integration and deamon build and test from integration install yq build images temp enable build images daemon it integration and deamon logs logs logs refactor docker stuff refactor docker stuff integration and deamon reorder tests reorder tests
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
78642b6
to
b0c3cdd
Compare
InoMurko
force-pushed
the
inomurko/latest-tag+develop
branch
from
559a6f9
to
3be9390
Compare
InoMurko
changed the title
InoMurko
pushed a commit
that referenced
this pull request
Jul 12, 2021
refactor: move self-signed certs to cert-manager and helmify Vault
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.