Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

omgx stress test eth #220

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

omgx stress test eth #220

wants to merge 31 commits into from

Conversation

trangtran-enya
Copy link

Description
Add stress tests for ETH

  • deposit
  • withdraw

- deposit ETH
- withdraw ETH
@petardenev
Copy link

adding do-not-merge label, until the stress tests are done to work properly with both integration and local environments.
Currently, there are a lot of issues with the code here:
`yarn test:integration:live
yarn run v1.22.10
$ IS_LIVE_NETWORK=true hardhat --network optimism-live test
stress tests
ETH stress tests
1) deposit ETH
WARNING: challenge period is greater than 60s (604800s), skipping test
2) withdraw ETH
0 passing (7m)
2 failing

  1. stress tests
    ETH stress tests
    deposit ETH:
    Error: invalid BigNumber value (argument="value", value=undefined, code=INVALID_ARGUMENT, version=bignumber/5.4.0)
    at Logger.makeError (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/logger/src.ts/index.ts:213:28)
    at Logger.throwError (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/logger/src.ts/index.ts:225:20)
    at Logger.throwArgumentError (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/logger/src.ts/index.ts:229:21)
    at Function.BigNumber.from (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/bignumber/src.ts/bignumber.ts:291:23)
    at toBN (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/bignumber/src.ts/bignumber.ts:347:27)
    at BigNumber.mul (/home/pe60/Documents/enya-labs/optimism-aws-integration-dev/node_modules/@ethersproject/bignumber/src.ts/bignumber.ts:92:43)
    at Object.executeDepositETH (test/shared/stress-test-helpers.ts:154:57)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Context. (test/stress-tests-eth.spec.ts:41:30)
  2. stress tests
    ETH stress tests
    withdraw ETH:
    TypeError: testctx.skip is not a function
    at Object.useDynamicTimeoutForWithdrawals (test/shared/env.ts:208:13)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.executeWithdrawETH (test/shared/stress-test-helpers.ts:126:5)
    at Context. (test/stress-tests-eth.spec.ts:73:19)
    error Command failed with exit code 2.
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.`

@CAPtheorem
Copy link

CAPtheorem commented Jul 28, 2021

this fails the unit tests - please fix:

An unexpected error occurred:
Error: test/stress-tests-erc20.spec.ts(13,25): error TS2307: Cannot find module '../artifacts/contracts/ERC20.sol/ERC20.json' or its corresponding type declarations.
Error: test/stress-tests-erc20.spec.ts(14,25): error TS2307: Cannot find module '../artifacts-ovm/contracts/ERC20.sol/ERC20.json' or its corresponding type declarations.

Copy link

@petardenev petardenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review https://github.com/omgnetwork/optimism/pull/220/checks?check_run_id=3220656367 as it seems the stress tests don't work properly when executed as part of the integration tests logic ran as part of the CI logic

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants