fix: set service name as a tag in metrics #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macaptain
pushed a commit
to omgnetwork/omg-childchain-v1
that referenced
this pull request
Nov 25, 2020
Currently the service name is part of the prefix for metrics, but it would be far better if it were a tag, so that services could be compared side by side in Datadog. See also: omgnetwork/elixir-omg#1786
InoMurko
approved these changes
Nov 25, 2020
macaptain
commented
Nov 25, 2020
| version: version | ||
| ], | ||
| host: dd_host, | ||
| port: dd_port, | ||
| prefix: "omg.#{service}", | ||
| prefix: "omg", |
There was a problem hiding this comment.
I may change this to "elixir" rather than "omg". I think the important part is that these metrics come from an elixir app.
pnowosie
approved these changes
Nov 25, 2020
Currently the service name is part of the prefix for metrics, but it would be far better if it were a tag, so that services could be compared side by side in Datadog.
macaptain
force-pushed
the
dd-metrics-service-tag
branch
from
1df32e7
to
f2e71d4
Compare
macaptain
pushed a commit
to omgnetwork/omg-childchain-v1
that referenced
this pull request
Nov 25, 2020
Currently the service name is part of the prefix for metrics, but it would be far better if it were a tag, so that services could be compared side by side in Datadog. See also: omgnetwork/elixir-omg#1786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the service name is part of the prefix for metrics, but it
would be far better if it were a tag, so that services could be compared
side by side in Datadog.
Rename the prefix to 'elixir'.
Changes
Testing
Check that metrics appear as omg.phoenix. ... with the service as a tag in Datadog. And this has been tested.