Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inomurko/1428 ci macos failing #1771

Closed
wants to merge 2 commits into from
Closed

Conversation

InoMurko
Copy link
Contributor

@InoMurko InoMurko commented Nov 18, 2020

No description provided.

Because API responses are always 200, even if there's an error message
in the body of the response, it's hard to get metrics from Datadog about
 the health of services.

What you see in Datadog traces:
* The service name (default 'web' for Phoenix applications) is the name
of the OMG application.
* Traces are tagged with application version number
* For API responses which error, the trace is flagged red as an error,
the error code is marked on the trace and the error message is found
in the tags.
@InoMurko InoMurko linked an issue Nov 18, 2020 that may be closed by this pull request
@InoMurko InoMurko force-pushed the inomurko/1428-ci-macos-failing branch from 9205fe6 to cdd1be5 Compare November 18, 2020 18:10
@InoMurko InoMurko closed this Nov 18, 2020
@InoMurko InoMurko deleted the inomurko/1428-ci-macos-failing branch November 18, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing on master branch
1 participant