feat: add new metadata to Datadog traces (attempt 2) #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add service, version and error metadata to traces in Datadog APM traces. What you see in the traces: * The service name (default 'web' for Phoenix applications) is the name of the OMG application. * Traces are tagged with application version number * For API responses which error, the trace is flagged red as an error, the error code is marked on the trace and the error message is found in the tags.
macaptain
force-pushed
the
add-metadata-to-dd-traces-2
branch
from
c7913e5 to
2ec3903
Compare
macaptain
changed the title
macaptain
commented
Nov 16, 2020
|
|
||
| test "api responses without errors get traced with metadata" do | ||
| :ok = Application.put_env(@app, :api_mode, :watcher) | ||
| version = OMGApplication.version() |
There was a problem hiding this comment.
Let me know if there's a better way to mock the call of version().
InoMurko
reviewed
Nov 18, 2020
Moved from Application to Configuration for WatcherRPC.
InoMurko
approved these changes
Nov 18, 2020
macaptain
force-pushed
the
add-metadata-to-dd-traces-2
branch
from
24eb949 to
d348983
Compare
InoMurko
reviewed
Nov 20, 2020
ayrat555
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-implementation of #1763
Add service, version and error metadata to traces in Datadog APM traces.
What you see in the traces:
Changes
Testing
Make API calls to the Watcher endpoints, and check the local-development environment APM Services in Datadog. Look for a service called "Watcher" and check the traces look as expected in the screenshot above.