-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solidity install #1287
Merged
Merged
fix: solidity install #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achiurizo
approved these changes
Feb 2, 2020
Need to pimp byzantine events tests 😫 |
unnawut
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion on ExMachina usage. Otherwise 👍
InoMurko
force-pushed
the
inomurko/barebuild_macos
branch
from
February 19, 2020 22:52
49f58d3
to
46d26d5
Compare
InoMurko
force-pushed
the
inomurko/barebuild_macos
branch
from
March 30, 2020 20:39
46d26d5
to
8c4cfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing nightly builds and moving them to main build but they're not mandatory for merge.
This way they're easier to observe when they get broken by PRs.
Overview
Mac build and barebone build fixes
Changes
Testing
Tests were already failing. Hopefully they'll pass now.