Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solidity install #1287

Merged
merged 13 commits into from
Mar 30, 2020
Merged

fix: solidity install #1287

merged 13 commits into from
Mar 30, 2020

Conversation

InoMurko
Copy link
Contributor

@InoMurko InoMurko commented Feb 2, 2020

Fixing nightly builds and moving them to main build but they're not mandatory for merge.
This way they're easier to observe when they get broken by PRs.

Overview

Mac build and barebone build fixes

Changes

  • Input and ouput sort as per DB query
  • Install Solidity 5.11 via RB url

Testing

Tests were already failing. Hopefully they'll pass now.

@coveralls
Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.1%) to 86.255% when pulling e3f2a95 on inomurko/barebuild_macos into e6e5b03 on master.

@InoMurko InoMurko marked this pull request as ready for review February 2, 2020 22:07
@InoMurko
Copy link
Contributor Author

InoMurko commented Feb 2, 2020

Need to pimp byzantine events tests 😫

Copy link
Contributor

@unnawut unnawut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion on ExMachina usage. Otherwise 👍

apps/omg_watcher_info/test/support/factory.ex Outdated Show resolved Hide resolved
@InoMurko InoMurko merged commit 280022b into master Mar 30, 2020
@InoMurko InoMurko deleted the inomurko/barebuild_macos branch March 30, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants