Upgrade Ivy to 2.5.2 #6388
Open
Upgrade Ivy to 2.5.2 #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version (2.4.0) was released in December 2015. Since then three releases have been made including CVE fixes and some features. Ivy 2.5+ requires Java 8 as the minimum version and includes new features like the ability to depend on timestamped SNAPSHOTs. See https://ant.apache.org/ivy/history/2.5.0/release-notes.html, https://ant.apache.org/ivy/history/2.5.1/release-notes.html and and https://ant.apache.org/ivy/history/2.5.2/release-notes.html for the list of associated changes
dominikl
approved these changes
May 15, 2024
There was a problem hiding this comment.
👍 Looks good to me. Builds are fine and the new ivy def gets used:
...
01:37:58 check-ivy:
01:37:58 Creating /home/omero/workspace/OMERO-build/src/etc/local.properties
01:37:58 Created dir: /home/omero/workspace/OMERO-build/src/target
01:37:58 :: Apache Ivy 2.5.2 - 20230817170011 :: https://ant.apache.org/ivy/ ::
01:37:58 :: loading settings :: file = /home/omero/workspace/OMERO-build/src/etc/ivysettings.xml
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The current version (2.4.0) was released in December 2015. Since then three releases have been made including CVE fixes and some features. Ivy 2.5+ requires Java 8 as the minimum version and includes new features like the ability to depend on timestamped SNAPSHOTs.
Testing this PR
The CI builds should still be passing and build the OMERO components. The artifacts and the resolved dependencies should be unmodified and can be compared directly to a build of OMERO without this change. All integration tests should be unaffected
Related reading
See https://ant.apache.org/ivy/history/2.5.0/release-notes.html, https://ant.apache.org/ivy/history/2.5.1/release-notes.html and and https://ant.apache.org/ivy/history/2.5.2/release-notes.html for the list of associated changes