Add --set to config append, --report to config {set,append,remove} #4791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
--set
option toomero config append
, to indicate a value should only be added if it's not already in the list, taking into account the defaults, see #4597Adds
--report
option toomero config {append,set,remove}
. This will always print outChanged: ...
if a change was made, and nothing if no change was made.Testing this PR
Check
omero config append/set/remove
behaves as before.Try something like
this should have no effect (E.g.
omero config get
, oromero web restart
and check the top-links) because this value is part of the standard defaults.Try it without
--set
, you should see the old behaviour i.e. the duplicate value is appendedAdd a different value, e.g.
Try
omero config {append,set,remove} --report
. If a change was made you should see a message such asChanged: Appended omero.web.ui.top_links:["BBC", "http://www.bbc.co.uk/"]
The idea behind this is to assist with Ansible deployments where you want to programmatically know whether or not a change was made.
Related reading