Set the color to grey if one channel. #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced of this being reasonable behaviour. If an image has a channel colour and a single channel, that channel colour should be used. Isn't the problem here the assignment of red as the channel colour in the absence of a channel colour? In the latter case defaulting to grey is reasonable, but for the former this is completely counter to expectations (and other software). |
|
@rleigh-dundee: if the color is already set, we use it. We only default to grey if no color set. see commit |
| Integer alpha = getValue(channel.getAlpha()); | ||
| RString name; | ||
| //color already set by Bio-formats | ||
| if (red != null && green != null && blue != null && alpha != null) { |
There was a problem hiding this comment.
I assume that if Bio-Formats set RGB then it would have also set α.
|
Works well, good to merge. |
|
Merging |
jburel
added a commit
that referenced
this pull request
Oct 28, 2014
Set the color to grey if one channel.
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this PR
before
after