Split view merged 10109

[will-moore]

Fixes a couple of bugs in Figure scripts. To test:

• Run the 'Split View Figure' from the custom UI in Insight (under 'Publishing Options') using a multi-channel image. Turn off some channels for the right-hand (merged) panel. See that your choice is reflected in the figure (Bug was that all channels were still on)
• Run Split_View_Figure and ROI_Split_Figure from the Scripts menu (script-generated UI) and for each one, fill in the "Merged Colours" key:value pair of fields with 0 and 255. The script should complete and you'll have a single blue channel in the merged Image of the figure.
• Repeat this, entering non-number strings into the Merged Colours fields. The scripts should still generate a figure, with warnings appearing in the 'Info' output.

[joshmoore]

@will-moore, @jburel -- Is this a case where it would be worth trying to fix the underlying problem first, i.e. being able to specify Map<Integer, Integer>? We may need to keep the explicit casts regardless for backwards compatibility.

[will-moore]

@joshmoore @jburel It certainly would be nice to specify Map<Integer, Integer> in the same way as we currently allow for lists etc. We'd also need to update the clients to query the data type of a Map and create the appropriate UIs etc. Right now it's quicker to make the change in the script itself (which will be backwards compatible as you say).

[joshmoore]

Did this get tested?

[will-moore]

@joshmoore No - I just noticed that it got missed.

[jburel]

@joshmoore: I forgot to add it to the list.

[scottlittlewood]

@will-moore @jburel

Split View Figure - Publishing Options

Original image with 2 channels:

Result: Passed - Figure Created with channels as grey and only select the first channel to be merged (using channel names).

Result: Passed - Figure Created with channels as colour and only select the second channel to be merged.

[scottlittlewood]

@will-moore @jburel

ROI Export - Scrips (0:255 - Blue Channel)

Original image with 2 channels:

Result - Passed

[scottlittlewood]

@will-moore @jburel

Split View Figure - Scripts (0:255 - Blue Channel)

Original image with 4 channels

Result: Passed

[scottlittlewood]

@will-moore @jburel

Split View Figure & ROI Figure - Scripts (Text in channel range)

Result: Passed

Info Output

Split View Figure

ROI Figure

[scottlittlewood]

@will-moore @jburel All test pass as described, ready for merge.

[jburel]

@will-moore, @joshmoore: Do we have a ticket to add support for Map<Integer, Integer>?

[joshmoore]

@jburel: I didn't add a ticket.

[joshmoore]

Ticket created https://trac.openmicroscopy.org.uk/ome/ticket/10210

[scottlittlewood]

@will-moore @joshmoore Tested on develop. All features passed the same as before.