Skip to content

Conversation

@will-moore
Copy link
Member

Simply added 'TIFF' option to the 'Format' parameter of each Figure Script.

To test, run each of the Figure Scripts, using the Scripts menu in Insight (TIFF option hasn't been added to "publication" UIs in Insight yet). Choose TIFF format and check that a tiff image is produced. Also check that PNG/JPEG still work for each script.

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@will-moore: I will synchronize insight today before we forget I have reponed https://trac.openmicroscopy.org.uk/ome/ticket/10000

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@will-moore: No issues noticed while running the scripts. For each script, save as jpeg/png and tiff

It will make sense to refactor that code so the mimetype is set in a utility class instead of having to update each script every time.

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@will-moore, @pwalczysko: we should add a more detailed section to the scripts clients scenario.
Those scripts are popular. I have created a ticket see http://trac.openmicroscopy.org.uk/ome/ticket/10058

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@will-moore: The script Batch_Image_Export.py should have the TIFF option

@jburel
Copy link
Member

jburel commented Dec 19, 2012

@will-moore: all scripts figures as the default format set to JPEG except Movie_Figure. No default set.
Batch_Image_Export.py exports as a default set to PNG. Time to unify that

@will-moore
Copy link
Member Author

@jburel That's the changes for your comments above

@jburel
Copy link
Member

jburel commented Dec 20, 2012

@will-moore:

  • All options of Batch_image_export work as expected.
  • Default correctly set.

As mentioned before, utility class will speed up the maintenance and the testing but that can be done in another PR.

jburel added a commit that referenced this pull request Dec 20, 2012
@jburel jburel merged commit f1abf9e into ome:dev_4_4 Dec 20, 2012
@scottlittlewood
Copy link

@jburel @will-moore Testing on gretzky I used the Batch Image Export script and exported as TIFF. The file annotation was created and added to the original image. On trying to download the file I get an Unhandled Exception error (white screen). Details below:

Server Url: http://gretzky.openmicroscop.org/
User: user-1
Image Url: https://gretzky.openmicroscopy.org.uk/omero/webclient/userdata/?show=image-6003
Annotation: Batch_image_export.zip (1.1mb)
Annotation Url: https://gretzky.openmicroscopy.org.uk/omero/webclient/annotation/25801/

@jburel
Copy link
Member

jburel commented Sep 9, 2013

--rebased-to #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants