-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels from tags #254
Add labels from tags #254
Conversation
var image_ids = this.map(function(s){return s.get('imageId')}) | ||
image_ids = "image=" + image_ids.join("&image="); | ||
// TODO: Use /api/ when annotations is supported | ||
var url = WEBINDEX_URL + "api/annotations/?type=tag&limit=1000&" + image_ids; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe offering the option later on to change the limit.
this will also depend on the number of images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This limit is just a very liberal cut-off to make sure we don't accidentally load millions of annotations, but that scenario is very edge-case.
The functionality works as expected. Happy to merge FMPOV. |
Can someone paste screenshots here? Are there any doc screenshots which then need updating? |
@joshmoore see screenshot above. I can see two screenshots needing replacing in http://help.openmicroscopy.org/figure.html#labels section. The screenshots are under points 13. and 15. |
Discussed today @will-moore will open a PR to update the screenshot in help |
@will-moore did you have a chance to look at the help PR? |
I was wondering whether to simply add the "Tags" option to fix existing screenshot (above) or to add the whole "Labels from Tags" workflow. |
Help PR opened at ome/ome-help#283 |
See https://trello.com/c/ZdmnimZj/64-labels-from-tags
This simply adds a label for every Tag on selected images.
To test:
[tags]
option.