allow main with empty args #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @k-dominik. (I'll note my private glee as I saw you forking the repo 😉) FWIW, this showed up after the last release: #277 (comment) |
requiring arguments breaks being able to use `main` as a python entry point. (this also breaks conda recipe currently as conda build tests the entry point)
3 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 13 13
Lines 1485 1485
=======================================
Hits 1260 1260
Misses 225 225
☔ View full report in Codecov by Sentry. |
joshmoore
reviewed
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiring arguments breaks being able to use
mainas a python entry point. (this also breaks conda recipe currently as conda build tests the entry point)It seems arguments to
mainare ... a testing feature here? For testing one could also manipulatesys.argv...