Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add entry for omero-web release #13

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 16, 2024

Add entry for release instructions of OMERO.web

@jburel jburel requested a review from knabar August 16, 2024 14:27
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page makes sense to me and is consistent with the release process page introduced for OMERO.server.

A few thoughts which should not hold the merging of this PR

  • the Docker section could likely include a paragraph as in the OMERO.server page indicating which repository should be tagged (I assume there is no version to maintain for this image)
  • is there any form of documentation update for an OMERO.web release?
  • the format of the announcement post lacks consistency with the one in OMERO.server
  • as more release process pages are migrated to the contributing documentations and entries are added to the left hand panel, we will reach the point where organising these pages with nested layout might increase the readability

@jburel
Copy link
Member Author

jburel commented Aug 16, 2024

I follow the format used by @knabar i.e. usage of dots.
We can modify that so all the announcements follow the same pattern

@jburel
Copy link
Member Author

jburel commented Aug 16, 2024

The page makes sense to me and is consistent with the release process page introduced for OMERO.server.

A few thoughts which should not hold the merging of this PR

  • the Docker section could likely include a paragraph as in the OMERO.server page indicating which repository should be tagged (I assume there is no version to maintain for this image)

I have added a link to the repo, no version to update. This might change if ome/omero-web-docker#78 is merged

  • is there any form of documentation update for an OMERO.web release?

Not really

  • the format of the announcement post lacks consistency with the one in OMERO.server

Comment above

  • as more release process pages are migrated to the contributing documentations and entries are added to the left hand panel, we will reach the point where organising these pages with nested layout might increase the readability

I will look into that in a follow-up PR

@jburel jburel merged commit 83abc79 into ome:master Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants